feat(MenuV2): add search feature in menu #4604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15cd2bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthprost
force-pushed
the
feat/menu-v2-search
branch
from
26479ef to
b4b3bcc
Compare
mhervouet
approved these changes
Dec 19, 2024
lisalupi
approved these changes
Dec 19, 2024
philibea
force-pushed
the
feat/menu-v2-search
branch
from
b4b3bcc to
15cd2bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4604 +/- ##
==========================================
+ Coverage 87.43% 87.49% +0.05%
==========================================
Files 335 339 +4
Lines 12722 12822 +100
Branches 3520 3487 -33
==========================================
+ Hits 11124 11219 +95
- Misses 1598 1603 +5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
searchable, when set totruea search bar will appear on the MenuV2. This can be useful for searching for a specific items quick. The searchbar is focused automatically when menu appear.hideOnClickItem: this is to replace function as children being used to close the menu when an item is clicked.Relevant logs and/or screenshots
Menu with prop
searchableandhideOnClickItemset totrue:Screen.Recording.2024-12-19.at.12.23.47.mov